Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oui-action-menu] compact mode has accessibility issue #656

Closed
antleblanc opened this issue Aug 14, 2020 · 1 comment · Fixed by #658
Closed

[oui-action-menu] compact mode has accessibility issue #656

antleblanc opened this issue Aug 14, 2020 · 1 comment · Fixed by #658

Comments

@antleblanc
Copy link
Member

antleblanc commented Aug 14, 2020

Description

Using <oui-action-menu compact> component raise an accessibility issue when
using Lighthouse report (for instance).

Adding the aria-label attribute, as mentioned into the documentation does not
provide any result (same with text attribute).

Steps to reproduce

  1. Use oui-action-menu story as an example (https://ovh.github.io/ovh-ui-kit/?path=/story/design-system-components-action-menu-webcomponent--compact).
  2. Pay attention that text attribute is correctly settled (and/or use the arial-label attribute)
  3. See errors (both attributes are ignored).

Expected behavior:

  • text should work.
  • aria-label should work.
  • No accessibility issue must be reported.

Actual behavior:

Following error is reported:

Button do not have an accessible name

button#ouiDropdown4.oui-action-button.ng-scope.ng-isolate-scope.oui-dropdown__trigger

Frequency:

5 (always)

Additional information

Canva link: https://ovh.github.io/ovh-ui-kit/iframe.html?id=design-system-components-action-menu-webcomponent--compact&viewMode=story
Live example: https://upufn.csb.app/
CodeSandbox: https://codesandbox.io/s/oui-action-menu-aria-label-upufn?file=/index.html

@AxelPeter
Copy link
Contributor

AxelPeter commented Aug 17, 2020

Hello,

A patch release has been made and this issue is now fixed in the package @ovh-ux/ui-kit@4.2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants