feat(batch): add support for batch GET calls #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbeuque74
requested changes
May 14, 2018
ovh/client.py
Outdated
| if kwargs: | ||
| kwargs = self._canonicalize_kwargs(kwargs) | ||
| batch = kwargs.pop('batch', None) |
There was a problem hiding this comment.
I would change it to _batch like we did with _need_auth to prevent conflicts with actual body parameters
|
And don't forget to sign your commit, in order to respect our contribution guidelines (https://github.com/ovh/python-ovh/blob/master/CONTRIBUTING.rst#contributing-to-python-ovh) |
Signed-off-by: Pierre Kuhner <pierre.kuhner@corp.ovh.com>
|
|
|
👍 |
|
Closing this as it pollutes my PR tab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for batch GET calls, e.g. retrieving multiple records in a single request:
GET /domain/zone/example.com/record/123456788,123456789,...Batch calls require a HTTP header
X-Ovh-Batchspecifying the split character (e.g.,).Signed-off-by: Pierre Kuhner pierre.kuhner@corp.ovh.com