Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: if status is 204, there is no response to parse #92

Merged
merged 1 commit into from
Sep 2, 2021
Merged

fix: if status is 204, there is no response to parse #92

merged 1 commit into from
Sep 2, 2021

Conversation

djangoliv
Copy link
Contributor

This is a proposal to handle response 204 in the client.

closes #91.

@djangoliv djangoliv mentioned this pull request Jan 21, 2021
Closed
@LukeMarlin
Copy link

Not a maintainer, but I would highly advise against putting a string here, best solution might be None!
@rbeuque74 thoughts?

@djangoliv
Copy link
Contributor Author

Thanks @LukeMarlin . Fixed.

@rbeuque74
Copy link
Member

Thanks for your contribution!

@rbeuque74 rbeuque74 merged commit e18b704 into ovh:master Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

204 response is not handled
3 participants
@djangoliv @LukeMarlin @rbeuque74