Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated MFAPasswordMaxDays entry in bastion.conf #71

Closed
axl89 opened this issue Nov 28, 2020 · 4 comments · Fixed by #72
Closed

Duplicated MFAPasswordMaxDays entry in bastion.conf #71

axl89 opened this issue Nov 28, 2020 · 4 comments · Fixed by #72
Labels
bug Something isn't working

Comments

@axl89
Copy link
Contributor

axl89 commented Nov 28, 2020

While doing a Chef cookbook to manage this awesome software, I found out that the MFAPasswordMaxDays entry is duplicated in the bastion.conf.dist file in v3.01.00:

# MFAPasswordMaxDays (int >= 0)
#    DESC: For the PAM UNIX password MFA, sets the maximum amount of days after which the password must be changed (see `chage -M')
# DEFAULT: 90
"MFAPasswordMaxDays": 90,
#
# MFAPasswordMaxDays (int >= 0)
#    DESC: For the PAM UNIX password MFA, sets the number of days before expiration on which the user will be warned to change his password (see `chage -W')
# DEFAULT: 15
"MFAPasswordMaxDays": 15,

I'm not sure which one you'd like to keep, so I can't make a PR, but I hope this issue is useful! 😄

@Alkorin Alkorin added the bug Something isn't working label Nov 28, 2020
Alkorin added a commit that referenced this issue Nov 28, 2020
Fix duplicate MFAPasswordMaxDays

Fixes #71
@Alkorin
Copy link
Member

Alkorin commented Nov 28, 2020

Thanks for the report!

It's not a duplicate entry but a wrong config name.

@speed47
Copy link
Collaborator

speed47 commented Nov 30, 2020

Side note @axl89, we have a Puppet module out since a few days, because that's what we happen to be using internally ;)
So that's cool you're working on a Chef cookbook!

speed47 pushed a commit to speed47/the-bastion that referenced this issue Nov 30, 2020
Fix duplicate MFAPasswordMaxDays

Fixes ovh#71
@axl89
Copy link
Contributor Author

axl89 commented Dec 1, 2020

Thanks, @speed47 ! I'll follow your work closely, I really like this project and we will start using it very soon in our production environments. I aim to maintain the cookbook up to date with your new changes and configurations! 😄

@speed47
Copy link
Collaborator

speed47 commented Dec 15, 2020

I'll try your cookbook when I find some time. We might want to reference it in the readme as a third party tool at some point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants