Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: plugin email without auth #170

Merged
merged 1 commit into from Jul 27, 2020
Merged

Conversation

wI2L
Copy link
Contributor

@wI2L wI2L commented Jul 27, 2020

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Refactor the email plugin to allow using it with SMTP servers that doesn't require authentication.

  • What is the current behavior? (You can also link to an open issue here)

Configuration fields smtp_username and smtp_password are mandatory.

  • What is the new behavior (if this is a feature change)?

The username and password fields are no longer required, and can be left empty. In this case, the mail.v2 package will simply try to connect to the SMTP server without authentication. See https://github.com/go-mail/mail/blob/v2.3.1/smtp.go#L122

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No, current configurations for this plugin will continue to work as expected.

Signed-off-by: William Poussier <william.poussier@gmail.com>
Copy link
Member

@rbeuque74 rbeuque74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, useful when using with internal smtp servers that might not require authentication

@rbeuque74 rbeuque74 merged commit 1dcf9f4 into master Jul 27, 2020
@rbeuque74 rbeuque74 deleted the email-plugin-noauth branch July 27, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants