-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add retry / delay on teststep #3
Conversation
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
process.go
Outdated
var errors []Failure | ||
var failures []Failure | ||
|
||
for retry := 0; retry <= e.retry; retry++ { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for retry := 0; retry < e.retry && !isOK ; retry++ {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
process.go
Outdated
break | ||
} | ||
// add errors / failures, only for last retry | ||
if retry == e.retry { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should not be in the for loop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
types.go
Outdated
) | ||
|
||
type ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you decide to make a type block
, you should put every in it.
it's up to you, but only one type block
of repeat type
everywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
we need timeout on executorwrapper too :) |
i could be interesting to be able to user venom to run golang unit tests, by initializing a testcase with a slice of steps and a *testing.T (of *testing.B) |
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
|
Signed-off-by: Yvonnick Esnault yvonnick.esnault@corp.ovh.com