This repository has been archived by the owner on May 30, 2022. It is now read-only.
Add CommunityProfile stream #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ry-DS
reviewed
Sep 18, 2021
| parent_stream_type = RepositoryStream | ||
| ignore_parent_replication_key = False | ||
| state_partitioning_keys = ["repo", "org"] | ||
| tolerated_http_errors = [404] |
There was a problem hiding this comment.
this might be a good thing to add to the README too since a project could technically not have a readme, and it would halt here. Good catch!
| self, prepared_request, context: Optional[dict] | ||
| ) -> requests.Response: | ||
| """Override private method _request_with_backoff to account for expected 404 Not Found erros.""" | ||
| # TODO - Adapt Singer |
| def _request_with_backoff( | ||
| self, prepared_request, context: Optional[dict] | ||
| ) -> requests.Response: | ||
| """Override private method _request_with_backoff to account for expected 404 Not Found erros.""" |
tap_github/client.py
Outdated
| extra_tags=extra_tags, | ||
| ) | ||
| if response.status_code in self.tolerated_http_errors: | ||
| self.logger.info("Request returned a tolerated error for {}".format(prepared_request.url)) |
There was a problem hiding this comment.
f strings are supported right? Prefer those since they are a lot nicer.
| return response | ||
|
|
||
| if response.status_code in [401, 403]: | ||
| self.logger.info("Failed request for {}".format(prepared_request.url)) |
| def parse_response(self, response: requests.Response) -> Iterable[dict]: | ||
| """Parse the response and return an iterator of result rows.""" | ||
| # TODO - Split into handle_reponse and parse_response. |
| @@ -71,13 +72,61 @@ def get_url_params( | |||
| params["since"] = since | |||
| return params | |||
|
|
|||
| def _request_with_backoff( | |||
There was a problem hiding this comment.
We never call the super (from what I see) which I'm guessing means we copy a lot of logic from the parent. Probably better to try change the underlying impl via a fork or message to the maintainer? Or maybe we can call the super and add extra code as needed.
|
@Ry-DS for some reason I had not seen these remarks. It's been merge on the parent main already, but feel free to open a new PR to make some improvements! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.