EPA-55: Remove IP remapping when contacting RISE in the diga-epa-lib #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francogrbac-oviva
requested review from
thomasrichner-oviva and
michelealbanese-oviva
michelealbanese-oviva
requested changes
Mar 20, 2024
| @@ -37,14 +36,10 @@ | |||
| import org.junit.jupiter.api.BeforeEach; | |||
| import org.junit.jupiter.api.Disabled; | |||
| import org.junit.jupiter.api.Test; | |||
| import org.slf4j.Logger; | |||
| import org.slf4j.LoggerFactory; | |||
|
|
|||
| @Disabled | |||
| class KonnektorServiceTest { | |||
There was a problem hiding this comment.
Suggested change
| class KonnektorServiceTest { | |
| // e2e test to write sample document to our test environment | |
| class KonnektorServiceAcceptanceTest { |
I think it would be helpful for future readers, also to explain why the test is disabled by default. feel free to rephrase better ofc
There was a problem hiding this comment.
renamed the class and added a comment
| @@ -98,12 +93,13 @@ private KonnektorService buildService() throws Exception { | |||
|
|
|||
| // these are the TLS client credentials as received from the Konnektor provider (e.g. RISE) | |||
| var keys = loadKeys(); | |||
| var uri = URI.create("https://localhost:4443"); | |||
| var uri = URI.create("https://10.156.145.103:443"); | |||
There was a problem hiding this comment.
could you extract it into a constant? the other magic values as well, makes it easier to change it in the future if we need it
There was a problem hiding this comment.
done, good point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.