Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: fix update diff on single value sets #325

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

jcaamano
Copy link
Collaborator

@jcaamano jcaamano commented Aug 16, 2022

The server was notifying single value set updates using XOR but
single value sets are notified with the final value.

fixes #324

Signed-off-by: Jaime Caamaño Ruiz jcaamano@redhat.com

@npinaeva
Copy link
Member

/lgtm
works now, thanks @jcaamano!

The server was notifying single value set updates using XOR but
single value sets are notified with the final value.

Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2874014633

  • 10 of 12 (83.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 74.83%

Changes Missing Coverage Covered Lines Changed/Added Lines %
server/transact.go 10 12 83.33%
Totals Coverage Status
Change from base Build 2825230608: 0.1%
Covered Lines: 4944
Relevant Lines: 6607

💛 - Coveralls

Copy link
Contributor

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm thanks for the code conslidation

@dcbw dcbw merged commit e8e40ba into ovn-org:main Aug 17, 2022
npinaeva added a commit to npinaeva/ovn-kubernetes that referenced this pull request Aug 18, 2022
Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
npinaeva added a commit to npinaeva/ovn-kubernetes that referenced this pull request Aug 18, 2022
Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
npinaeva added a commit to npinaeva/ovn-kubernetes that referenced this pull request Aug 19, 2022
Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
girishmg pushed a commit to girishmg/ovn-kubernetes that referenced this pull request Oct 27, 2023
Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
(cherry picked from commit 4c26b7c)
Signed-off-by: Yun Zhou <yunz@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libovsdb server doesn't allow to reset Ptr column to empty
5 participants