Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IPv6 only KIND deployment to CI matrix. #1343

Merged
merged 5 commits into from Jul 27, 2020
Merged

Add IPv6 only KIND deployment to CI matrix. #1343

merged 5 commits into from Jul 27, 2020

Conversation

Billy99
Copy link
Contributor

@Billy99 Billy99 commented May 18, 2020

Signed-off-by: Billy McFall 22157057+Billy99@users.noreply.github.com

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

@coveralls
Copy link

coveralls commented May 18, 2020 •
edited

Coverage Status

Coverage increased (+0.01%) to 58.628% when pulling 66796d2 on Billy99:billy99-ipv6-ci into cdb174c on ovn-org:master.

@Billy99 Billy99 force-pushed the billy99-ipv6-ci branch 28 times, most recently from fac7d53 to 3dd2799 Compare May 22, 2020 12:42
@Billy99 Billy99 force-pushed the billy99-ipv6-ci branch 4 times, most recently from 39bee80 to 1168eaf Compare July 24, 2020 19:42
@dcbw dcbw mentioned this pull request Jul 25, 2020
Closed
@Billy99 Billy99 force-pushed the billy99-ipv6-ci branch 3 times, most recently from 6c8dc84 to 427c74d Compare July 25, 2020 17:57
@aojea
Copy link
Contributor

aojea commented Jul 25, 2020

You can't use an ipv6 address for the external API, docker does not support ipv6 port mapping

Status: Downloaded newer image for kindest/haproxy:2.1.1-alpine
8a312084e9b26a92cded8a13928d29d22e573c040d96af6087905bec61a6ba17
docker: Error response from daemon: driver failed programming external connectivity on endpoint ovn-external-load-balancer (a05cac0578165e2431e7a473389adf867feeaffdfb9b97631036de882d1e6a6c): Error starting userland proxy: listen tcp [fe80::20d:3aff:fe0f:df71]:11337: bind: invalid argument.
make: *** [install-kind] Error 1
##[error]Process completed with exit code 2.

@aojea
Copy link
Contributor

aojea commented Jul 25, 2020

Use always the ipv4 host address for the apiserver field, this will keep compatibility and people will be able to connect with kubectl from outside

@aojea
Copy link
Contributor

aojea commented Jul 25, 2020

🤞

@aojea
Copy link
Contributor

aojea commented Jul 25, 2020

great 🎉

@Billy99
Copy link
Contributor Author

Billy99 commented Jul 26, 2020

@trozet PTAL
Let me know if you want to see the changes before I squash them with the earlier commit.

@stbenjam stbenjam mentioned this pull request Jul 26, 2020
Closed
trozet
trozet reviewed Jul 26, 2020
View reviewed changes
contrib/kind.sh Outdated
@@ -313,6 +295,10 @@ docker build -t ovn-daemonset-f:dev -f Dockerfile.fedora .
# and since OVN has to provide the connectivity to service
# it can not be bootstrapped

# This is the address of the node with the control-plane
# If HA, multiple control-plane nodes, KIND deploys
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this Yoda speak? :)

trozet
trozet requested changes Jul 26, 2020
View reviewed changes
Copy link
Contributor

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me @Billy99, just squash it with the first commit and then I think we are good to go

@trozet trozet mentioned this pull request Jul 26, 2020
Merged
@Billy99
KIND improvements
3bcebf6 
Per suggestions from @aojea, improve how KIND is used.

Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
@Billy99
Support IPv6 only deployment
7cf0ba1 
Update scripts to support IPv6 only.
Resolves: ovn-org#977

Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
@Billy99
Add IPv6 only KIND deployment to CI matrix.
28937cd 
Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
@Billy99
Limit CI test matrix per issue ovn-org#1401
a818426 
Per comment in ovn-org#1401, limit the test cases. This does not fix the root cause
of the issue, but addresses a comment in the issue:
 ovn-org#1401 (comment)

Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
@Billy99 Billy99 force-pushed the billy99-ipv6-ci branch 3 times, most recently from 4bd505b to fe26900 Compare July 27, 2020 02:05
@Billy99
Update vendor/ebay/libovsdb to pickup IPv6 patch
66796d2 
ebay/libovsdb had the following issue that was fixed upstream:

Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20)

When trying to connect to an ovsdb instance via IPv6, encountered an IPv6
parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...),
the code uses strings.Split(endpoint, ":"), which does not take into account
the ':' in an IPv6 address.

Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
@trozet trozet merged commit fe9a632 into ovn-org:master Jul 27, 2020
@Billy99 Billy99 deleted the billy99-ipv6-ci branch July 27, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwinship danwinship danwinship left review comments

@erig0 erig0 erig0 left review comments

@aojea aojea aojea left review comments

@trozet trozet trozet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Billy99 @coveralls @aojea @danwinship @erig0 @trozet