hybrid-overlay: fix host route to hybrid overlay subnets #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First time I have seen that e2e test fail. I will address the retry timer for getting the destination pod IP with a PR. Ty. |
trozet
requested changes
Jun 5, 2020
trozet
approved these changes
Jun 5, 2020
|
/retest |
dcbw
force-pushed
the
fix-hybrid-overlay-host-route
branch
from
982d750
to
3ba375b
Compare
|
/hold |
dcbw
changed the title
dcbw
force-pushed
the
fix-hybrid-overlay-host-route
branch
from
3ba375b
to
c52ec34
Compare
dcbw
changed the title
|
@trozet @nerdalert fixed now, PTAL thanks |
danwinship
reviewed
Jun 8, 2020
| @@ -290,7 +308,6 @@ var _ = Describe("Hybrid Overlay Node Linux Operations", func() { | |||
|
|
|||
| //FIXME | |||
| //Expect(fexec.CalledMatchesExpected()).To(BeTrue(), fexec.ErrorDesc) | |||
| validateNetlinkState(node1Subnet) | |||
There was a problem hiding this comment.
lgtm
but does the rewriting of the test fix the scattered CalledMatchesExpected FIXMEs?
There was a problem hiding this comment.
@danwinship no, it doesn't touch the ovs resync logic that broke the CalledMatchesExpected() stuff.
Don't use direct byte manipulation of the node subnet, otherwise it's changed for all subsequent uses and that causes the host route via the management port for the hybrid overlay cluster subnet to get a .6 address instead of the expected .3. In addition the testcases didn't have the right hybrid overlay CLI options to enable the right code checks. Signed-off-by: Dan Williams <dcbw@redhat.com>
dcbw
force-pushed
the
fix-hybrid-overlay-host-route
branch
from
c52ec34
to
d17f517
Compare
|
Repushed to fix conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use direct byte manipulation of the node subnet, otherwise
it's changed for all subsequent uses and that causes the host route
via the management port for the hybrid overlay cluster subnet to
get a .6 address instead of the expected .3.
@trozet @rcarrillocruz @dave-tucker