CNI: quit waiting for pod flows for obsoleted ADD #1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcbw
reviewed
Nov 11, 2020
Given a scenario where we have: 1. pod A added 2. pod A deleted 3. kubelet has already started CNI ADD for first event 4. pod A added 5. kubelet starts 2nd sandbox CNI ADD The current code will remove the original OVS interface for the first event, however the cmdAdd for the first event will still be running waiting for flows (up to 20 seconds). Really if hte pod loses its interface, that cmdAdd iteration is now invalid and we should just return out immediately with an error. Signed-off-by: Tim Rozet <trozet@redhat.com>
trozet
force-pushed
the
quit_waiting_for_flows1
branch
from
fb7a52e
to
edd836e
Compare
|
/lgtm now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a scenario where we have:
The current code will remove the original OVS interface for the first
event, however the cmdAdd for the first event will still be running
waiting for flows (up to 20 seconds). Really if hte pod loses its
interface, that cmdAdd iteration is now invalid and we should just
return out immediately with an error.
Signed-off-by: Tim Rozet trozet@redhat.com