Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump kubernetes to 1.20 #1904

Merged
merged 7 commits into from
Dec 17, 2020
Merged

bump kubernetes to 1.20 #1904

merged 7 commits into from
Dec 17, 2020

Conversation

aojea
Copy link
Contributor

@aojea aojea commented Dec 8, 2020

@aojea
Copy link
Contributor Author

aojea commented Dec 8, 2020

There are some new e2e test in this release, per example, the ones for hostNetowkr pods connectivity

@coveralls
Copy link

coveralls commented Dec 8, 2020

Coverage Status

Coverage increased (+0.05%) to 55.12% when pulling 4a0bb04 on aojea:k8s1.20 into 77ceb8d on ovn-org:master.

@aojea
Copy link
Contributor Author

aojea commented Dec 9, 2020

some of the failures are in NetworkPolicy related to a bug fixed in master kubernetes/kubernetes#96856
other the SCTP failures that will be addressed by kubernetes/kubernetes#96717

[sig-network] Services should implement service.kubernetes.io/headless

I don´t have clear why this doesnt´t work , from the top of my head is a DNS test

@aojea
Copy link
Contributor Author

aojea commented Dec 9, 2020

super cool , the new endpoint slices service controller passes all the upstream tests

ovn-ci / e2e (shard-conformance, false, true, HA, local, dualstack, Dualstack, true, true) (pull_request) Successful in 33m

@aojea
Copy link
Contributor Author

aojea commented Dec 9, 2020

/retest
this looks good , the 2 job failures are network policy ones ... but not the same in both

@aojea
Copy link
Contributor Author

aojea commented Dec 10, 2020

/retest

1 similar comment
@aojea
Copy link
Contributor Author

aojea commented Dec 10, 2020

/retest

@dcbw
Copy link
Contributor

dcbw commented Dec 11, 2020

I dont know why the build-k8s job is still "waiting for status to be reported", since everything in CI is green.

/lgtm

@aojea
Copy link
Contributor Author

aojea commented Dec 11, 2020

I dont know why the build-k8s job is still "waiting for status to be reported", since everything in CI is green.

this commits removes it a8317dd , so it is waiting because it will no longer exist after we merge :)

# Install latest e2e test binary
# The e2e binaries are built from https://github.com/aojea/kubernetes-e2e-binaries
# Current e2e binary versions is latest 1.19 tag v1.19.4
curl -LO https://github.com/aojea/kubernetes-e2e-binaries/releases/download/d360454c/e2e.test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would prefer if we just make an ovn-org repo to do this instead of it being in @aojea repo...thoughts @dcbw @danwinship @girishmg ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, let me see if I can find the upstream binaries, I know that they publish them somewhere for the CI

Copy link
Contributor Author

@aojea aojea Dec 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no worries, I´ve managed to get the URL to the upstream binaries that is a much better solution and are published for these situations, so projects in the ecosystem don´t have to do the building that is expensive in terms of resources
PTAL to the new commit 49400ee

Antonio Ojea added 7 commits December 16, 2020 10:39
Signed-off-by: Antonio Ojea <aojea@redhat.com>
We are compiling the e2e.test and kubect binaries from the
kubernetes repo to match the Kubernetes version used in kind.

However, this binaries doesn't need to match the exact version
of the cluster under test, and we can use precompiled binaries
that are publicly available, saving more than 500Mb of storage and
5 minutes in the CI.

It's also a great benefit for local developments, so you don't
need to checkout and recompile the kubernetes sources.

Signed-off-by: Antonio Ojea <aojea@redhat.com>
Signed-off-by: Antonio Ojea <aojea@redhat.com>
Signed-off-by: Antonio Ojea <aojea@redhat.com>
Signed-off-by: Antonio Ojea <aojea@redhat.com>
Signed-off-by: Antonio Ojea <aojea@redhat.com>
Signed-off-by: Antonio Ojea <aojea@redhat.com>
@aojea
Copy link
Contributor Author

aojea commented Dec 16, 2020

/retest

@aojea
Copy link
Contributor Author

aojea commented Dec 16, 2020

3 test failures for 1 job only

ovn-ci / e2e (shard-conformance, false, true, HA, shared, ipv6, IPv6, false, true) (pull_request) Failing after 42m — e2e (shard-conformance, false, true, HA, shared, ipv6, IPv6, false, true)

@aojea
Copy link
Contributor Author

aojea commented Dec 16, 2020

ok, it went through now
@trozet PTAL, we use the kubernetes official binaries now

@dcbw
Copy link
Contributor

dcbw commented Dec 16, 2020

/lgtm

@dcbw dcbw merged commit d69e9d9 into ovn-org:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants