Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes errors when adding NAT with existing entry #2105

Merged
merged 1 commit into from Mar 18, 2021

Commits on Mar 17, 2021

  1. Fixes errors when adding NAT with existing entry

    When adding SNAT per pod with an existing entry, the code will fail and
    report an error because with OVN we cannot do lr-nat-del and lr-nat-add
    in the same OVSDB transaction. This is because OVSDB evaluates the
    lr-nat-add and thinks there will be a conflict because an entry already
    exists.
    
    Additionally, during gateway init for a node, this failure may also
    occur. In which case the GR will be left with missing config.
    
    To handle this case, split add and delete into separate transactions,
    and only del/add if the entry is missing.
    
    Signed-off-by: Tim Rozet <trozet@redhat.com>
    trozet committed Mar 17, 2021
    Copy the full SHA
    a3978f2 View commit details
    Browse the repository at this point in the history