Add routes for pod: fail only after checking all the gw addresses / ips #2293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding routes to pod, we fail inside the inner loop returning an error. What happens is that if the pod has two ip addresses, and the gw is set only for the second address, the function will mistakenly return an error. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What this PR does and why is it needed
When adding routes to pod, we fail inside the inner loop returning an error. What happens is that if the pod has two ip addresses, and the gw is set only for the second address, the function will mistakenly return an error.
- Special notes for reviewers
- How to verify it
- Description for the changelog