Add hbo-lr-policy only if config.HybridOverlay.ClusterSubnets is set #2314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we do not have a config parser that checks if HybridOverlay.ClusterSubnets is set if HybridOverlay.Enabled is true, before adding the lr-in-policy we should check if there are any clustersubnets in the config. Since we don't have a default value for this field it ends up creating policies that have nil dst fields. Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
|
/assign @trozet |
|
/lgtm |
|
/lgtm |
trozet
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we do not have a config parser that checks if
HybridOverlay.ClusterSubnets is set if HybridOverlay.Enabled is true,
before adding the lr-in-policy we should check if there are any
clustersubnets in the config. Since we don't have a default value
for this field it ends up creating policies that have nil dst
fields.
Fixes #2313
Signed-off-by: Surya Seetharaman suryaseetharaman.9@gmail.com