Succesor for PR 2331 [fix reserve joinSwitch LRP IPs] #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
master.go: Use of ensureJoinLRPIPs, which also checks the running DB. logical_switch_manager: ensureJoinLRPIPs now also looks into the running DB and fills the cache on a hit. Move getJoinLRPAddresses from gateway to logical_switch_manager Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>
logical_switch_manager: During startup, getJoinLRPAddresses validates the active joinLRPAddress against the node's subnet, but because of the early state, the node's subnets are empty, instead we should validate against the join switch's subnets that are already initialised. Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>
|
Thank you for pushing for these changes. |
|
/retest |
alexanderConstantinescu
changed the title
|
Merging this, following agreement: #2331 (comment) |
alexanderConstantinescu
added a commit
to alexanderConstantinescu/ovn-kubernetes
that referenced
this pull request
Aug 31, 2021
After the modifications made to `ensureJoinLRPIPs` by PR: ovn-org#2434 the function "lost" thread-safety. This meant that we could have one go-routine - spawned by the network policy watchers - and another by the node watcher, race and try to `Allocate` the same IP for the same logical switch. Causing the second to error with `ErrAllocated`. We can re-work the existing locks and have `ensureJoinLRPIPs` and `releaseJoinLRPIPs` locks that span the caching functions, ensuring that that all cache operations are thread-safe. Signed-off-by: Alexander Constantinescu <aconstan@redhat.com>
trozet
pushed a commit
to trozet/ovn-kubernetes
that referenced
this pull request
Sep 14, 2021
After the modifications made to `ensureJoinLRPIPs` by PR: ovn-org#2434 the function "lost" thread-safety. This meant that we could have one go-routine - spawned by the network policy watchers - and another by the node watcher, race and try to `Allocate` the same IP for the same logical switch. Causing the second to error with `ErrAllocated`. We can re-work the existing locks and have `ensureJoinLRPIPs` and `releaseJoinLRPIPs` locks that span the caching functions, ensuring that that all cache operations are thread-safe. Signed-off-by: Alexander Constantinescu <aconstan@redhat.com>
andreaskaris
pushed a commit
to andreaskaris/ovn-kubernetes
that referenced
this pull request
Oct 6, 2021
After the modifications made to `ensureJoinLRPIPs` by PR: ovn-org#2434 the function "lost" thread-safety. This meant that we could have one go-routine - spawned by the network policy watchers - and another by the node watcher, race and try to `Allocate` the same IP for the same logical switch. Causing the second to error with `ErrAllocated`. We can re-work the existing locks and have `ensureJoinLRPIPs` and `releaseJoinLRPIPs` locks that span the caching functions, ensuring that that all cache operations are thread-safe. Signed-off-by: Alexander Constantinescu <aconstan@redhat.com>
astoycos
pushed a commit
to astoycos/ovn-kubernetes
that referenced
this pull request
Nov 30, 2021
After the modifications made to `ensureJoinLRPIPs` by PR: ovn-org#2434 the function "lost" thread-safety. This meant that we could have one go-routine - spawned by the network policy watchers - and another by the node watcher, race and try to `Allocate` the same IP for the same logical switch. Causing the second to error with `ErrAllocated`. We can re-work the existing locks and have `ensureJoinLRPIPs` and `releaseJoinLRPIPs` locks that span the caching functions, ensuring that that all cache operations are thread-safe. Signed-off-by: Alexander Constantinescu <aconstan@redhat.com>
kyrtapz
pushed a commit
to kyrtapz/ovn-kubernetes
that referenced
this pull request
Nov 21, 2022
After the modifications made to `ensureJoinLRPIPs` by PR: ovn-org#2434 the function "lost" thread-safety. This meant that we could have one go-routine - spawned by the network policy watchers - and another by the node watcher, race and try to `Allocate` the same IP for the same logical switch. Causing the second to error with `ErrAllocated`. We can re-work the existing locks and have `ensureJoinLRPIPs` and `releaseJoinLRPIPs` locks that span the caching functions, ensuring that that all cache operations are thread-safe. Signed-off-by: Alexander Constantinescu <aconstan@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What this PR does and why is it needed
I have no clue what is happening with Github and its actions on PR: #2331 , it's cancelling the build during every run. Hence try to get a CI signal on it here.
- Special notes for reviewers
- How to verify it
- Description for the changelog