add support for multiple flow monitoring protocols and for IPv6 endpoint in existing tests #2592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricky-rav
force-pushed
the
dev_SDN-2059
branch
from
e245ea2
to
3dc4efe
Compare
ricky-rav
force-pushed
the
dev_SDN-2059
branch
from
3dc4efe
to
28c7017
Compare
|
/retest |
ricky-rav
force-pushed
the
dev_SDN-2059
branch
2 times, most recently
from
cbba2c9
to
01f76cf
Compare
astoycos
reviewed
Oct 26, 2021
astoycos
reviewed
Oct 26, 2021
astoycos
reviewed
Oct 26, 2021
astoycos
reviewed
Oct 26, 2021
|
I think we will soon need to actually run the ipv6 control-plane tests :) Some small nits + questions but otherwise /lgtm |
trozet
requested changes
Oct 26, 2021
ricky-rav
force-pushed
the
dev_SDN-2059
branch
3 times, most recently
from
bf44987
to
e4962b8
Compare
trozet
requested changes
Oct 27, 2021
There was a problem hiding this comment.
@ricky-rav can you remove the merge commit? You should be able to just rebase your branch to master and add your commit on top.
ricky-rav
force-pushed
the
dev_SDN-2059
branch
2 times, most recently
from
714fe7c
to
adf3db7
Compare
|
/retest |
dcbw
reviewed
Nov 22, 2021
…int in existing netflow test - Existing netflow export test now supports netflow v5, ipfix, sflow. - The original test only validated the export of netflow v5 (legacy netflow) data, which does not support IPv6 by design. In order to validate flow data export in an IPv6 cluster, we can now choose between IPFIX and sflow; also, the test now supports an IPv6 endpoint; - For the time being we're only testing netflow v5 in IPv4 (as before) and sflow in IPv6, because: (1) The test itself is long (~5 minutes); (2) The current implementation of the flow collector container (cloudfare/goflow) doesn't support IPFIX data generated by OVS (cloudflare/goflow#99) Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
ricky-rav
force-pushed
the
dev_SDN-2059
branch
from
adf3db7
to
af04455
Compare
ricky-rav
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) The test itself is long (~5 minutes);
(2) The current implementation of the flow collector container (cloudfare/goflow) doesn't support IPFIX data generated by OVS (Openvswitch ovs-vsctl connection cloudflare/goflow#99)
This patch addresses https://issues.redhat.com/browse/SDN-2059
- How to verify it