Fixes finding default gateway for configured GW interface #2782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code for determining the default gateway was not taking into consideration if the gateway interfaces was provided via config and would return any default gateway found on the host. This is an issue when a system has more than 1 default gateway, as well as if a user provided an interface other than the real default gateway interface. If the gateway interface is provided via config, the code now scopes default routes found to only that interface. Signed-off-by: Tim Rozet <trozet@redhat.com>
|
would like to just pull this downstream as a sanity test, since we always set gateway interface there |
|
downstream: openshift/ovn-kubernetes#939 |
|
downstream looks good..removing hold |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for determining the default gateway was not taking into
consideration if the gateway interfaces was provided via config and
would return any default gateway found on the host. This is an issue
when a system has more than 1 default gateway, as well as if a user
provided an interface other than the real default gateway interface.
If the gateway interface is provided via config, the code now scopes
default routes found to only that interface.
Signed-off-by: Tim Rozet trozet@redhat.com