Remove egress firewall cache #2959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It really isn't necessary and this simplifies the code. Signed-off-by: Tim Rozet <trozet@redhat.com>
|
@ricky-rav @msherif1234 PTAL |
ricky-rav
reviewed
Apr 29, 2022
| @@ -189,9 +189,18 @@ func (oc *Controller) addEgressFirewall(egressFirewall *egressfirewallapi.Egress | |||
| ef.Lock() | |||
| defer ef.Unlock() | |||
| // there should not be an item already in egressFirewall map for the given Namespace | |||
There was a problem hiding this comment.
nit: so this comment is now outdated
| fws = append(fws, fw.Name) | ||
| } | ||
| } | ||
| return fmt.Errorf("error attempting to add egressFirewall %s to namespace %s when it already has an egressFirewalls: %s", |
There was a problem hiding this comment.
nit: maybe "...when it already has egressFirewall(s): %s"
msherif1234
reviewed
Apr 29, 2022
| if err != nil { | ||
| return fmt.Errorf("unable to check number of existing egress firewalls: %v", err) | ||
| } else if len(existing) > 1 { | ||
| fws := []string{} |
There was a problem hiding this comment.
why would the same egfw exits more than once in the same ns ? I wonder if len(existing) > 1 is sufficient to flag the error ?
msherif1234
reviewed
Apr 29, 2022
| @@ -189,9 +189,18 @@ func (oc *Controller) addEgressFirewall(egressFirewall *egressfirewallapi.Egress | |||
| ef.Lock() | |||
| defer ef.Unlock() | |||
There was a problem hiding this comment.
do we still need to lock now giving the changes u did to the delete ?
|
turns out I actually need the cache for #3002 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It really isn't necessary and this simplifies the code.
Signed-off-by: Tim Rozet trozet@redhat.com