initial pods are not wired for hybrid overlay #3595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobTanenbaum
requested review from
trozet,
dcbw,
girishmg and
jcaamano
as code owners
JacobTanenbaum
force-pushed
the
windows-toggle
branch
from
2ce9ac2
to
e6c6586
Compare
trozet
requested changes
May 16, 2023
| @@ -476,7 +497,7 @@ func (n *NodeController) handleHybridOverlayMACIPChange(node *kapi.Node) error { | |||
|
|
|||
| // EnsureHybridOverlayBridge sets up the hybrid overlay bridge | |||
| func (n *NodeController) EnsureHybridOverlayBridge(node *kapi.Node) error { | |||
| if atomic.LoadUint32(&n.initialized) == 1 { | |||
| if atomic.LoadUint32(&n.initialized) >= 1 { | |||
There was a problem hiding this comment.
can you change the atomic comparisons to constants? Now you are using a new value of 2, but I'm not sure what that indicates (without referring to your comment in the struct). So maybe const iota with their names suggesting what the event is you are looking for would be clearer?
There was a problem hiding this comment.
@trozet changed the states to const using iota, how does it look now?
dcbw
reviewed
May 16, 2023
JacobTanenbaum
force-pushed
the
windows-toggle
branch
2 times, most recently
from
a944392
to
5109dfc
Compare
|
Changes Unknown when pulling 61541cf on JacobTanenbaum:windows-toggle into ** on ovn-org:master**. |
JacobTanenbaum
force-pushed
the
windows-toggle
branch
from
5109dfc
to
42439d9
Compare
dcbw
reviewed
May 18, 2023
When toggling hybrid overlay the linux nodes can miss wiring the pods on start-up if allocating the hybrid overlay DRIP and DRMAC takes too long. Fix this issue by passing a podLister to the node controller and running the AddPods() command on all local pods once on startup after DRIP and DRMAC are set. Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com>
JacobTanenbaum
force-pushed
the
windows-toggle
branch
from
42439d9
to
61541cf
Compare
dcbw
reviewed
May 18, 2023
trozet
approved these changes
May 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When toggling hybrid overlay the linux nodes can miss setting up the initial pods on start-up if allocating the hybrid overlay DRIP and DRMAC takes too long.
Fix this issue by passing a podLister to the node controller and running the AddPods() command on all local pods once on startup after DRIP and DRMAC are set.
- What this PR does and why is it needed
- Special notes for reviewers
- How to verify it
- Description for the changelog