Allow hostNetwork ingress for network policies with empty namespace selector #3669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npinaeva
requested review from
trozet,
dcbw,
girishmg and
jcaamano
as code owners
npinaeva
force-pushed
the
np-hostnetwork-ns
branch
from
05fba1a
to
b9914c8
Compare
|
consider maybe changing the acl to match shared addrset || special host address set |
selector. The previous version used shared address sets for empty namespace selector to reuse the address set, but it didn't include a special config.Kubernetes.HostNetworkNamespace that only has an address set, but no pods. This difference may break existing network policies for hostNetwork pods, therefore we explicitly add this address sets for an empty namespace selector. Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
npinaeva
force-pushed
the
np-hostnetwork-ns
branch
from
b9914c8
to
5e3dc65
Compare
|
Good point! Updated, ptal @trozet |
trozet
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version used shared address sets for empty namespace
selector to reuse the address set, but it didn't include a special
config.Kubernetes.HostNetworkNamespace that only has an address set,
but no pods. This difference may break existing network policies for
hostNetwork pods, therefore we explicitly add this address sets for an
empty namespace selector.