Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes panic with delete NAT operations #3714

Merged
merged 1 commit into from
Jun 28, 2023

Commits on Jun 28, 2023

  1. Fixes panic with delete NAT operations

    Regression introduced by:
    25d892c
    
    Would end up appending a nil NAT and causing an NPE when trying to
    execute EquivalentNAT:
    
    panic: runtime error: invalid memory address or nil pointer dereference
    [signal SIGSEGV: segmentation violation code=0x1 addr=0x78 pc=0x178ea7b]
    
    goroutine 140 [running]:
    github.com/ovn-org/ovn-kubernetes/go-controller/pkg/libovsdbops.isEquivalentNAT(0x0, 0xc002e6cea0)
    	/go/src/github.com/openshift/ovn-kubernetes/go-controller/pkg/libovsdbops/router.go:935 +0x9b
    github.com/ovn-org/ovn-kubernetes/go-controller/pkg/libovsdbops.DeleteNATsOps({0x24aa068, 0xc0008c0fc0}, {0x0, 0x0, 0x0}, 0xc002e1a4e0, {0xc000130c48, 0x1, 0xc00106f6f8?})
    	/go/src/github.com/openshift/ovn-kubernetes/go-controller/pkg/libovsdbops/router.go:1087 +0x728
    
    Signed-off-by: Tim Rozet <trozet@redhat.com>
    trozet committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    1541b58 View commit details
    Browse the repository at this point in the history