Ensure ovnkube-controller does not go remote->local #3735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trozet
force-pushed
the
fix_remote_to_local_ic
branch
4 times, most recently
from
637ba65
to
733e073
Compare
jcaamano
approved these changes
Jul 5, 2023
jcaamano
force-pushed
the
fix_remote_to_local_ic
branch
from
733e073
to
86f1559
Compare
At ovnkube-controller start up, it may attempt to start adding resources for a node that does not yet have its annotation, but should be considered local. This is especially the case in OpenShift when going from phase1 -> phase 2 upgrade and ovnkube-node on the node will annotate its zone id. In this case ovnkube-controller will start too early and program NBDB resources as remote for the node. Then when the node is annotated, it will program NBDB resources as local. Since we cannot be sure that all remote feature configuration in NBDB is removed when going from remote -> local we need to avoid this case. It also makes no sense to program NBDB when there are no nodes in the zone. This commit adds a wait to make sure at least one node in the cluster is in the ovnkube-controller's managed zone. Thanks @numansiddique for the idea. Signed-off-by: Tim Rozet <trozet@redhat.com>
jcaamano
force-pushed
the
fix_remote_to_local_ic
branch
from
86f1559
to
5e6787d
Compare
hmm I thought we spoke about local->remote here on friday, I was a bit confused about @trozet 's comment here: https://github.com/ovn-org/ovn-kubernetes/pull/3735/files#diff-cf3d012028107d0065b038f3ddf3f2fd82b14518b09aa7193b45bb5ef7eefebfR334 which mentions local -> remote but the title and description in the PR are focused on remote -> local, was about to talk to @trozet when he is back, but I guess its ok we merged this since its harmless. |
... unless there are no nodes! 😛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At ovnkube-controller start up, it may attempt to start adding resources for a node that does not yet have its annotation, but should be considered local. This is especially the case in OpenShift when going from phase1 -> phase 2 upgrade and ovnkube-node on the node will annotate its zone id. In this case ovnkube-controller will start too early and program NBDB resources as remote for the node. Then when the node is annotated, it will program NBDB resources as local.
Since we cannot be sure that all remote feature configuration in NBDB is removed when going from remote -> local we need to avoid this case. It also makes no sense to program NBDB when there are no nodes in the zone.
This commit adds a wait to make sure at least one node in the cluster is in the ovnkube-controller's managed zone.
Thanks @numansiddique for the idea.