Delete address sets after acls that reference them #3766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovn-controller syntax errors Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
npinaeva
requested review from
trozet,
dcbw,
girishmg and
jcaamano
as code owners
dcbw
approved these changes
Jul 12, 2023
tssurya
approved these changes
Jul 13, 2023
|
this bug is only causing a warning in ovn-controller logs, so we would need to check ovn-controller logs to find that (on a node that had pods affected by the network policy), so it may be tricky to test |
|
it is POSSIBLE to test this with UT but I don't like the solution. Using Eventually() we can poll the ovn database to make sure we don't get into a state that we don't want before we get into the expected state...that would catch this but it would be racey (we would only catch it if the database is in bad state at the time we poll) and we would need to know the bad states to poll for. |
trozet
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid ovn-controller syntax errors.
For some stupid reason I changed the cleanup order when implemented
PodSelectorAddressSet, fix it