Fix Netpol event handler #3834
Merged
Fix Netpol event handler #3834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
types that have update function. Move network policy related functionality to the network_controller_policy_event_handler.go. Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
npinaeva
requested review from
trozet,
dcbw,
girishmg and
jcaamano
as code owners
jcaamano
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add AddressSetPodSelectorType to the types that have update functions, otherwise Delete handler will be called on every update.
Introduced here https://github.com/ovn-org/ovn-kubernetes/pull/3382/files#diff-bfe36f3f355a5f23fa5a91c6d7227b49aaefb78514769265dc91900d13a461a3L27
Add DefaultEventHandler to reduce code duplication.