Trivial: Improve CloudPrivateIPConfig logs when it cannot be assigned. #3908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the cloud provider is still working on de-associating an egress IP from a node, it is possible that a following association will be stopped. This commit implements a better log explaining this scenario. Reported-at: https://issues.redhat.com/browse/OCPBUGS-18647 Signed-off-by: Flavio Fernandes <flaviof@redhat.com>
flavio-fernandes
requested review from
trozet,
dcbw,
girishmg and
jcaamano
as code owners
|
/assign @kyrtapz |
|
/lgtm |
kyrtapz
approved these changes
Sep 15, 2023
| @@ -228,7 +228,8 @@ func (eIPC *egressIPClusterController) executeCloudPrivateIPConfigOps(egressIPNa | |||
| klog.Infof("CloudPrivateIPConfig: %s already assigned to node: %s", cloudPrivateIPConfigName, cloudPrivateIPConfig.Spec.Node) | |||
| continue | |||
| } | |||
| return fmt.Errorf("cloud create request failed for CloudPrivateIPConfig: %s, err: item exists", cloudPrivateIPConfigName) | |||
| return fmt.Errorf("cloud request failed for CloudPrivateIPConfig: %s, err: cannot be assigned to node %s because cloud has it in node %s", | |||
There was a problem hiding this comment.
what does op.toAdd resolve to? A node name?
There was a problem hiding this comment.
what does
op.toAddresolve to? A node name?
yes
|
/lgtm |
jcaamano
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the cloud provider is still working on de-associating an egress IP from a node, it is possible that a following association will be stopped. This commit implements a better log explaining this scenario.
Reported-at: https://issues.redhat.com/browse/OCPBUGS-18647