skip hybrid overlay nodes when upgrading to interconnect #3917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobTanenbaum
requested review from
trozet,
dcbw,
girishmg and
jcaamano
as code owners
jcaamano
force-pushed
the
OCPBUGS-18352
branch
from
4c2b759
to
b7ab1ac
Compare
having a hybrid overlay node in the cluster will cause upgrading to interconnect to fail currently. We need to skip hybrid overlay ndoes when checking for node-subnet annotations as they do not have one. Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com> asd
JacobTanenbaum
force-pushed
the
OCPBUGS-18352
branch
from
b7ab1ac
to
8ae2133
Compare
JacobTanenbaum
changed the title
JacobTanenbaum
changed the title
|
manually tested the upgrade path and these changes work |
|
/lgtm |
|
Test failures appear to be flakes (eg |
|
Fix included in accepted release 4.15.0-0.nightly-2023-09-27-073353 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
having a hybrid overlay node in the cluster will cause upgrading to interconnect to fail currently.
We need to skip hybrid overlay ndoes when checking for node-subnet annotations as they do not have one.
would fix: https://issues.redhat.com/browse/OCPBUGS-18352
- What this PR does and why is it needed
- Special notes for reviewers
- How to verify it
- Description for the changelog