Run node certificate manager in hybrid overlay #3939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrtapz
requested review from
trozet,
dcbw,
girishmg and
jcaamano
as code owners
kyrtapz
force-pushed
the
cert_mgr_windows
branch
4 times, most recently
from
8e48df4
to
a2a89dc
Compare
jcaamano
force-pushed
the
cert_mgr_windows
branch
from
a2a89dc
to
65e974d
Compare
hybrid-overlay-node runs on windows nodes and should be able to set the same annotations as ovnkube-node. Signed-off-by: Patryk Diak <pdiak@redhat.com>
kyrtapz
force-pushed
the
cert_mgr_windows
branch
from
65e974d
to
8932957
Compare
jcaamano
approved these changes
Sep 29, 2023
|
Fix included in accepted release 4.15.0-0.nightly-2023-09-29-192501 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hybrid-overlay-noderuns on windows nodes and should be able to set the same annotations as ovnkube-node.This means that it requires also requires a per-node certificate.
/cc @jcaamano @JacobTanenbaum