New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vhost-vDPA support #3958
vhost-vDPA support #3958
Conversation
Details about the deviceInfo spec are available at: https://github.com/k8snetworkplumbingwg/device-info-spec Signed-off-by: Leonardo Milleri <lmilleri@lmilleri-thinkpadp1gen3.remote.csb>
Signed-off-by: Leonardo Milleri <lmilleri@redhat.com>
Changes unknown when pulling 589b345 on lmilleri:vdpa-2nd-if into ** on ovn-org:master**. |
lgtm |
Hi @lmilleri, I am running our CI jobs for smartNics and we are seeing sriov pods fail to start up with this change with the following error in oc describe. Any ideas for where we should start to resolve this?
|
cc/ @wizhaoredhat |
@lmilleri Was there any necessary changes to the Network attachment definition or any other CRDs? |
@SalDaniele @wizhaoredhat Is the ovn-kube log telling anything more? Just a speculation, could it be a json serialization problem when not passing the deviceInfo param in the network attachment definition?
This is an example of NAD:
with the additional capability. I'll be back to work on Thursday and I'll have a look to it first thing. |
Consider this change also as a possible reason |
On a second thought, I'm quite sure the problem is due to a last minute change in the govdpa library. |
Hi @lmilleri thanks for taking a look, I verified this PR fixes the problem |
The current PR introduces support for vhost-vDPA devices.
There are 2 main changes:
DeviceInfo support on ovn-k
See deviceInfo spec at https://github.com/k8snetworkplumbingwg/device-info-spec
This commit is required for introducing vhost-vdpa
vhost-vDPA device support
Please make sure to merge this PR first: #3868