Fix remove remote pod when no IPs annotated #3976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick test downstream here: openshift/ovn-kubernetes#1944 |
jcaamano
force-pushed
the
fix-remove-remote-pod
branch
from
d28eb74
to
ec226ba
Compare
|
typos |
jcaamano
force-pushed
the
fix-remove-remote-pod
branch
from
ec226ba
to
ab991a0
Compare
|
re-worded the test case name |
jcaamano
force-pushed
the
fix-remove-remote-pod
branch
2 times, most recently
from
91bdddd
to
b9b5dde
Compare
trozet
previously approved these changes
Oct 24, 2023
|
need to fix gofmt |
jcaamano
force-pushed
the
fix-remove-remote-pod
branch
3 times, most recently
from
75737c2
to
5ba1454
Compare
This was recently changed incorrectly. A pod can be deleted with no IPs annotated so don't assume that is an error. Incidentally fix the case for a live migrated pod as well which would have failed in the same way before. Fixes: ovn-org#3919 Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
jcaamano
force-pushed
the
fix-remove-remote-pod
branch
from
5ba1454
to
531c462
Compare
trozet
approved these changes
Oct 25, 2023
|
Fix included in accepted release 4.15.0-0.nightly-2023-10-27-135451 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was recently changed incorrectly. A pod can be deleted with no IPs annotated so don't assume that is an error.
Incidentally fix the case for a live migratable pod as well which would have failed in the same way before.
Fixes: #3919