kubevirt: Ignore completed virt-launcher pods #3990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinqon
force-pushed
the
kubevirt-ignore-completed-virt-launcher-pod
branch
2 times, most recently
from
04a5f25
to
d1e5820
Compare
qinqon
force-pushed
the
kubevirt-ignore-completed-virt-launcher-pod
branch
2 times, most recently
from
b78d756
to
6740e48
Compare
qinqon
requested review from
trozet,
dcbw,
girishmg and
jcaamano
as code owners
qinqon
force-pushed
the
kubevirt-ignore-completed-virt-launcher-pod
branch
from
6740e48
to
e2609f4
Compare
jcaamano
reviewed
Nov 3, 2023
| if !IsPodLiveMigratable(pod) { | ||
| return false, nil | ||
| return true, nil |
There was a problem hiding this comment.
This is counter-intuitive. Why don't you do the IsPodLiveMigratable check first, and return false if the pod is not migratable.
go-controller/pkg/kubevirt/pod.go
Outdated
| } | ||
| vmPods, err := findVMRelatedPods(client, pod) | ||
| if err != nil { | ||
| return false, fmt.Errorf("failed finding related pods for pod %s/%s when checking live migration left overs: %v", pod.Namespace, pod.Name, err) | ||
| return true, fmt.Errorf("failed finding related pods for pod %s/%s when checking live migration left overs: %v", pod.Namespace, pod.Name, err) |
There was a problem hiding this comment.
Why? Does it matter if we are returning an error? false is the better convention here so it is weird that you had to change this value.
qinqon
force-pushed
the
kubevirt-ignore-completed-virt-launcher-pod
branch
from
e2609f4
to
043b146
Compare
go-controller/pkg/kubevirt/pod.go
Outdated
| @@ -123,11 +123,14 @@ func EnsurePodAnnotationForVM(watchFactory *factory.WatchFactory, kube *kube.Kub | |||
| return podAnnotation, nil | |||
| } | |||
|
|
|||
| // IsMigratedSourcePodStale return true if there are other pods related to | |||
| // to it and any of them has newer creation timestamp. | |||
| // IsMigratedSourcePodStale return false is the pod is live migratable and not completed | |||
There was a problem hiding this comment.
IsMigratedSourcePodStale return false if the pod is live migratable, not completed and is the running VM pod with newest creation timestamp
qinqon
force-pushed
the
kubevirt-ignore-completed-virt-launcher-pod
branch
from
043b146
to
ce91a2c
Compare
qinqon
force-pushed
the
kubevirt-ignore-completed-virt-launcher-pod
branch
3 times, most recently
from
5d03941
to
bbe0491
Compare
When a live migration fails at completed virt-launcher pod with newer creation timestamp is lingering in the system so the virt-launcher that is really running the VM is hidden by it and routes are wrongly reconstructed. This change take into account if the pod is completed to ignore it marking it as stale. Signed-off-by: Enrique Llorente <ellorent@redhat.com>
qinqon
force-pushed
the
kubevirt-ignore-completed-virt-launcher-pod
branch
from
bbe0491
to
4f9b4c2
Compare
jcaamano
approved these changes
Nov 3, 2023
|
Fix included in accepted release 4.15.0-0.nightly-2023-11-16-214550 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What this PR does and why is it needed
When a live migration fails at completed virt-launcher pod with newer
creation timestamp is lingering in the system so the virt-launcher that
is really running the VM is hidden by it and routes are wrongly
reconstructed. This change take into account if the pod is completed to
ignore it marking it as stale.
Closes https://issues.redhat.com/browse/OCPBUGS-22767
- How to verify it
It includes a unit test that emulate the result of failing migration, completed virt-launcher pod with newer creation timestamp.
- Description for the changelog
kubevirt: Ignore completed virt-launcher pods