Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 2 OVS metrics upcall_flow_limit_kill and upcall_flow_limit_hit. #4016

Merged
merged 1 commit into from Dec 8, 2023
Merged

Add 2 OVS metrics upcall_flow_limit_kill and upcall_flow_limit_hit. #4016

merged 1 commit into from Dec 8, 2023

Conversation

npinaeva
Copy link
Member

They may be used to create alerts to signal when OVS is having performance issues.

Based on input from OVN team:

ovs-appctl coverage/read-counter upcall_flow_limit_kill
If the value on this one changes, that may be a trigger to fire an alert.  Coverage is increased every time the condition gets hit, the log appears only once.

The coverage counter:
ovs-appctl coverage/read-counter upcall_flow_limit_hit
Indicates that the upcall is not installing a flow into a datapath.  Potentially deserve to be an alert as well.

@npinaeva
Add 2 OVS metrics upcall_flow_limit_kill and upcall_flow_limit_hit.
47bec2e 
They may be used to create alerts to signal when OVS is having
performance issues.

Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
@npinaeva
Copy link
Member Author

/cc @igsilya @trozet

@martinkennelly martinkennelly self-assigned this Nov 21, 2023
martinkennelly
martinkennelly approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@martinkennelly martinkennelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

trozet
trozet approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @npinaeva !

@trozet trozet merged commit a1754fb into ovn-org:master Dec 8, 2023
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trozet trozet trozet approved these changes

@martinkennelly martinkennelly martinkennelly approved these changes

@dcbw dcbw Awaiting requested review from dcbw

@girishmg girishmg Awaiting requested review from girishmg

@jcaamano jcaamano Awaiting requested review from jcaamano

Assignees

@martinkennelly martinkennelly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@npinaeva @trozet @martinkennelly