-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubevirt, live migration: ensure VM tolerates migration failure #4023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiqueb
requested review from
trozet,
dcbw,
girishmg and
jcaamano
as code owners
November 21, 2023 12:14
/cc @qinqon |
qinqon
suggested changes
Nov 21, 2023
maiqueb
force-pushed
the
add-kv-failed-migration-test
branch
from
November 21, 2023 16:42
f6a8d28
to
ad6aac0
Compare
qinqon
suggested changes
Nov 22, 2023
maiqueb
force-pushed
the
add-kv-failed-migration-test
branch
from
November 22, 2023 15:37
ad6aac0
to
d11f546
Compare
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
maiqueb
force-pushed
the
add-kv-failed-migration-test
branch
from
November 22, 2023 15:38
d11f546
to
09cd6ad
Compare
qinqon
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
jcaamano
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What this PR does and why is it needed
This PR ensures a KubeVirt VM tolerates a failed migration - meaning the VM stays in the original pod, but is for all effects available.
- Special notes for reviewers
- How to verify it
- Description for the changelog