Ignore hybrid-overlay nodes from EgressIP controller #4093
Conversation
kyrtapz
requested review from
trozet,
dcbw,
girishmg,
jcaamano and
tssurya
as code owners
EgressIP is not supported on hybrid-overlay nodes. Exclude hybrid-overlay nodes from EgressIP controller to avoid issues related to missing annotations. Signed-off-by: Patryk Diak <pdiak@redhat.com>
kyrtapz
force-pushed
the
eip_with_ho_nodes
branch
from
eb4fcd5
to
63641aa
Compare
|
/assign @tssurya |
| @@ -80,6 +85,12 @@ func (h *egressIPClusterControllerEventHandler) UpdateResource(oldObj, newObj in | |||
| case factory.EgressNodeType: | |||
| oldNode := oldObj.(*v1.Node) | |||
| newNode := newObj.(*v1.Node) | |||
|
|
|||
| // EgressIP is not supported on hybrid overlay nodes | |||
| if util.NoHostSubnet(newNode) { | |||
There was a problem hiding this comment.
do we need to handle case where old node == linux and new node == windows so we need to tear down the EIP configs? asking because I came across aeb9817 and assuming it is needed somehow for live migration? Seems like nodes can switch between HO and not? Wondering if that logic needs to be considered for EIPs or we stick to the this is not supported script?
There was a problem hiding this comment.
EgressIP is not currently expected to work during live migration. The feature should still work after the migration is completed and the changes in the PR don't affect that.
Handling nodes moving to HO for egressIP requires more effort, especially configuring the appropriate OVN flows etc.
There was a problem hiding this comment.
ack agreed as of now that this is not in this PR's scope then.
EgressIP is not supported on hybrid-overlay nodes.
Exclude hybrid-overlay nodes from EgressIP controller to avoid issues related to missing annotations.
/cc @martinkennelly