-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubevirt e2e stabilizing refactor #4145
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes unknown |
e13179a
to
ea76570
Compare
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Using the "Reuse" golang http client connection attribute to check that the connection is not broken is a little hard to debug, this change replace the http client and http agnhost server with a simple golang TCP server injected using fedora coreos ignition, its simpler and test is faster. Signed-off-by: Enrique Llorente <ellorent@redhat.com>
ea76570
to
a7aa34d
Compare
/hold |
We don't have "reset by peer" error at server this time and we see that the connection is at the server Failing at
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What this PR does and why is it needed
The kubevirt e2e tests are flaky, sometimes the persistent connection between tests and VM get broken and others the curl to ovn.org to check north soutgh traffic fail.
To fix those the following changes are introduced:
ovn.org
withkubernetes.default.svc.cluster.local
to verify north/south traffic without external domain dependency.Closes #3986
- Special notes for reviewers
This PR has being tested with 12 jobs in parallel run two time at author's fork
https://github.com/qinqon/ovn-kubernetes/actions/runs/7830706778/job/21366399247?pr=10
- Description for the changelog
Stabilize kubeirt e2e tests