kubevirt, e2e: Fill in the http server pods slice #4224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinqon
requested review from
trozet,
dcbw,
girishmg,
jcaamano and
tssurya
as code owners
✅ Deploy Preview for subtle-torrone-bb0c84 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
qinqon
force-pushed
the
kubevirt-e2e-fill-in-httpsevertestpods
branch
from
f23d0b1
to
394bdf5
Compare
qinqon
force-pushed
the
kubevirt-e2e-fill-in-httpsevertestpods
branch
from
394bdf5
to
78913ec
Compare
tssurya
added
area/e2e-testing
feature/kubevirt-live-migration
qinqon
force-pushed
the
kubevirt-e2e-fill-in-httpsevertestpods
branch
4 times, most recently
from
9d4bff0
to
0f5a20a
Compare
At kubevirt e2e tests the pods create at each nodes where not being added to the pods slice, this means that they were not created and the test for east/west communication was not run. This change fill in again that slice so the test is run again. Signed-off-by: Enrique Llorente <ellorent@redhat.com>
qinqon
force-pushed
the
kubevirt-e2e-fill-in-httpsevertestpods
branch
from
0f5a20a
to
a180787
Compare
jcaamano
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What this PR does and why is it needed
At kubevirt e2e tests the pods create at each nodes where not being added to the pods slice, this means that they were not created and the test for east/west communication was not run.
This change fill in again that slice so the test is run again.