Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EQoS: Set force:true for server-side-apply #4314

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

tssurya
Copy link
Member

@tssurya tssurya commented Apr 29, 2024

- What this PR does and why is it needed

Force: true was not set on EQoS status updates in ovnkube-controller
causes conflicts when trying to patch

- Special notes for reviewers

- How to verify it

- Description for the changelog
Use force:true when doing server side apply

Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
@tssurya
Copy link
Member Author

tssurya commented Apr 29, 2024

/assign @pperiyasamy

@coveralls
Copy link

Coverage Status

coverage: 52.438% (+0.03%) from 52.408%
when pulling dff5dc7 on tssurya:egressqos-status
into 361d573 on ovn-org:master.

@pperiyasamy
Copy link
Contributor

/lgtm

Thanks @tssurya , The EgressQoS CRD is also not yet updated in d/s https://github.com/openshift/cluster-network-operator/blob/master/bindata/network/ovn-kubernetes/common/001-crd.yaml#L433-L435, Can you do that, please ?

@tssurya
Copy link
Member Author

tssurya commented Apr 29, 2024

/lgtm

Thanks @tssurya , The EgressQoS CRD is also not yet updated in d/s https://github.com/openshift/cluster-network-operator/blob/master/bindata/network/ovn-kubernetes/common/001-crd.yaml#L433-L435, Can you do that, please ?

oh! woops nice catch :) I thought when we added the RBAC we took care of updating the CRD, yeah will fix that as well as part of same bug

@tssurya
Copy link
Member Author

tssurya commented Apr 29, 2024

@tssurya tssurya added kind/bug All issues that are bugs and PRs opened to fix bugs feature/egress-qos Issues related to egressQoS labels Apr 30, 2024
@tssurya tssurya merged commit ff78f95 into ovn-org:master Apr 30, 2024
38 checks passed
@openshift-merge-robot
Copy link

Fix included in accepted release 4.16.0-0.nightly-2024-05-04-214435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/egress-qos Issues related to egressQoS kind/bug All issues that are bugs and PRs opened to fix bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants