Add pip requirements to fix TLS validation issues. #86
Conversation
Fixes #85 Signed-off-by: Paulo Pires <pjpires@gmail.com>
| @@ -1,6 +1,8 @@ | |||
| pbr>=1.8 | |||
| netaddr>=0.7.18 | |||
| requests>=2.9.1 | |||
| requests | |||
There was a problem hiding this comment.
Can you explain the rationale behind changing version requirements of "requests"?
There was a problem hiding this comment.
I have to admit I'm not a Python developer so I tried to Google my way out of this issue. In between experiments, I was suggested to updated requests. Perhaps it was because it would require a newer version or urllib3 or because it already included a fix that urllib3 didn't had at the time of the writing of said suggestion.
All I can say, is that it works now!
|
@salv-orlando Your expertise is needed here. Would removing the versioning for requests cause issues in other ways? |
|
I did some testing and I did not see any negative effects of your change. So I will go ahead and merge it. If we hear about any issues, we will re-visit. |
|
👍 |
Fixes #85