northd: Move router ports SB PB options sync to sync_to_sb_pb node.

It also moves the logical router port IPv6 prefix delegation
updates to "sync-from-sb" engine node.

With these changes, northd engine node doesn't need to do much
for SB Port binding changes other than updating 'op->sb'.  And
there is no need to fall back to recompute.  Prior to this patch
northd_handle_sb_port_binding_changes() was returning false for
all SB port binding updates except for the VIF PBs.  This patch
now handles updates to all the SB port binding by setting 'op->sb'.

Acked-by: Han Zhou <hzhou@ovn.org>
Acked-by: Dumitru Ceara <dceara@redhat.com>
Signed-off-by: Numan Siddique <numans@ovn.org>

northd/en-northd.c

@@ -189,7 +189,7 @@ northd_sb_port_binding_handler(struct engine_node *node,
     northd_get_input_data(node, &input_data);
 
     if (!northd_handle_sb_port_binding_changes(
-        input_data.sbrec_port_binding_table, &nd->ls_ports)) {
+        input_data.sbrec_port_binding_table, &nd->ls_ports, &nd->lr_ports)) {
         return false;
     }
 

northd/en-sync-sb.c

@@ -288,7 +288,8 @@ en_sync_to_sb_pb_run(struct engine_node *node, void *data OVS_UNUSED)
     const struct engine_context *eng_ctx = engine_get_context();
     struct northd_data *northd_data = engine_get_input_data("northd", node);
 
-    sync_pbs(eng_ctx->ovnsb_idl_txn, &northd_data->ls_ports);
+    sync_pbs(eng_ctx->ovnsb_idl_txn, &northd_data->ls_ports,
+             &northd_data->lr_ports);
     engine_set_node_state(node, EN_UPDATED);
 }