Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ovn-controller: Stop dropping bind_vport requests immediately after h…
…andling. ovn-controller immediately removes the vport_bindings requests that were generated by VIFs after handling them locally, this approach is intended to avoid binding the vport to one VIF only and allocate the vport between the different VIFs that exist in the vport:virtual-parents. Although the behavior mentioned above is correct, in some cases when the SB Database is busy the transaction that binds this vport to the desired VIF/chassis can fail and the controller will not re-try to bind the vport again because we deleted the bind_vport request in the previous loop/TXN. This patch aims to change the above behavior by storing the bind_vport requests for a bit longer time and this is done by the following: 1. mark each new bind_vport request as new. 2. loop0: ovn-controller will try to handle this bind_vport request for the first time as usual (no change). 3. loop0: ovn-controller will try to delete the already handled bind_vport request as usual but first, it will check if this request is marked as new and if so the controller will mark this request as an old request and keep it, otherwise remove it. 4. loop1: ovn-controller will try to commit the same change again for the old request, if the previous commit in loop0 succeeded the change will not have any effect on SB, otherwise we will try to commit the same vport_bind request again. 5. loop1: delete the old bind_vport request. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1954659 Signed-off-by: Mohammad Heib <mheib@redhat.com> Acked-by: Ales Musil <amusil@redhat.com> Signed-off-by: Mark Michelson <mmichels@redhat.com>
- Loading branch information