Fix memleak in ovn-nbctl when args can't be parsed

The leak is reported for asan runs. Signed-off-by: Ihar Hrachyshka <ihrachys@redhat.com> Signed-off-by: Mark Michelson <mmichels@redhat.com> Acked-by: Mark Michelson <mmichels@redhat.com>
ovn-org · Jun 27, 2022 · 9c29f55 · 9c29f55
1 parent 543c23c
commit 9c29f55
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/utilities/ovn-dbctl.c b/utilities/ovn-dbctl.c
@@ -202,6 +202,13 @@ ovn_dbctl_main(int argc, char *argv[],
         error = ctl_parse_commands(argc - optind, argv_ + optind,
                                    &local_options, &commands, &n_commands);
         if (error) {
+            ovsdb_idl_destroy(idl);
+            idl = the_idl = NULL;
+
+            for (int i = 0; i < argc; i++) {
+                free(argv_[i]);
+            }
+            free(argv_);
             ctl_fatal("%s", error);
         }