Skip to content

Commit

Permalink
Don't mention packet cloning when failing to find tunnel
Browse files Browse the repository at this point in the history
Packet cloning is relevant to multichassis ports only, so the message
made no sense for single chassis ports with no additional_chassis.

Even for multichassis ports, this part of the message is redundant and
confusing. It's better to remove it.

Signed-off-by: Ihar Hrachyshka <ihrachys@redhat.com>
Signed-off-by: Dumitru Ceara <dceara@redhat.com>
  • Loading branch information
booxter authored and dceara committed Oct 10, 2023
1 parent 0e49f49 commit a9051a1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions controller/physical.c
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ get_remote_tunnels(const struct sbrec_port_binding *binding,
static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 1);
VLOG_WARN_RL(
&rl, "Failed to locate tunnel to reach main chassis %s "
"for port %s. Cloning packets disabled for the chassis.",
"for port %s.",
binding->chassis->name, binding->logical_port);
} else {
struct tunnel *tun_elem = xmalloc(sizeof *tun_elem);
Expand All @@ -363,7 +363,7 @@ get_remote_tunnels(const struct sbrec_port_binding *binding,
static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 1);
VLOG_WARN_RL(
&rl, "Failed to locate tunnel to reach additional chassis %s "
"for port %s. Cloning packets disabled for the chassis.",
"for port %s.",
binding->additional_chassis[i]->name, binding->logical_port);
continue;
}
Expand Down

0 comments on commit a9051a1

Please sign in to comment.