Skip to content

Commit

Permalink
m4: Replace obsolete AC_ERROR with AC_MSG_ERROR.
Browse files Browse the repository at this point in the history
AC_ERROR is triggering a warning on systems with autoconf 2.70+:

  $ ./boot.sh
  ...
  configure.ac:174: warning: The macro `AC_ERROR' is obsolete.
  configure.ac:174: You should run autoupdate.
  ...

Replace with AC_MSG_ERROR that is supported in all versions of
autoconf that we care about (2.63+).

Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Signed-off-by: Dumitru Ceara <dceara@redhat.com>
  • Loading branch information
igsilya authored and dceara committed Aug 17, 2023
1 parent b9b2d2d commit b32e868
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions acinclude.m4
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ AC_DEFUN([OVN_CHECK_OVS], [
fi
OVSDIR=$(cd "$(eval echo "$with_ovs_source")"; pwd)
if test ! -f "$OVSDIR/vswitchd/bridge.c"; then
AC_ERROR([$OVSDIR is not an OVS source directory])
AC_MSG_ERROR([$OVSDIR is not an OVS source directory])
fi
AC_MSG_RESULT([$OVSDIR])
Expand All @@ -426,13 +426,16 @@ AC_DEFUN([OVN_CHECK_OVS], [
*) OVSBUILDDIR=`pwd`/$OVSBUILDDIR ;;
esac
if test ! -f "$OVSBUILDDIR/config.h"; then
AC_ERROR([$OVSBUILDDIR is not a configured OVS build directory])
AC_MSG_ERROR([$OVSBUILDDIR is not a configured OVS build directory])
fi
elif test -f "$OVSDIR/config.h"; then
# If separate build dir is not specified, use src dir.
OVSBUILDDIR=$OVSDIR
else
AC_ERROR([OVS source dir $OVSDIR is not configured as a build directory (either run configure there or use --with-ovs-build to point to the build directory)])
AC_MSG_ERROR(m4_normalize([
OVS source dir $OVSDIR is not configured as a build directory
(either run configure there or use --with-ovs-build to point
to the build directory)]))
fi
AC_MSG_RESULT([$OVSBUILDDIR])
AC_SUBST(OVSBUILDDIR)
Expand Down

0 comments on commit b32e868

Please sign in to comment.