Skip to content

Commit

Permalink
ovn-util: Remove unused ovn_parse_internal_version_minor.
Browse files Browse the repository at this point in the history
The only user of this function was removed in a cited commit.  And
it is unlikely to be used in the future, since we have feature flags
in the database instead.

Fixes: 3013c28 ("northd: ovn-controller: Use ct_mark.natted only when ct_lb_mark is used.")
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Dumitru Ceara <dceara@redhat.com>
(cherry picked from commit a105020)
  • Loading branch information
igsilya authored and dceara committed Mar 2, 2023
1 parent c521275 commit c3d8797
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 23 deletions.
18 changes: 0 additions & 18 deletions lib/ovn-util.c
Original file line number Diff line number Diff line change
Expand Up @@ -769,24 +769,6 @@ ovn_get_internal_version(void)
N_OVNACTS, OVN_INTERNAL_MINOR_VER);
}

unsigned int
ovn_parse_internal_version_minor(const char *ver)
{
const char *p = ver + strlen(ver);
for (int i = 0; i < strlen(ver); i++) {
if (*p == '.') {
break;
}
p--;
}

unsigned int minor;
if (ovs_scan(p, ".%u", &minor)) {
return minor;
}
return 0;
}

#ifdef DDLOG
/* Callbacks used by the ddlog northd code to print warnings and errors. */
void
Expand Down
5 changes: 0 additions & 5 deletions lib/ovn-util.h
Original file line number Diff line number Diff line change
Expand Up @@ -262,11 +262,6 @@ bool ip_address_and_port_from_lb_key(const char *key, char **ip_address,
* value. */
char *ovn_get_internal_version(void);

/* Parse the provided internal version string and return the "minor" part which
* is expected to be an unsigned integer followed by the last "." in the
* string. Returns 0 if the string can't be parsed. */
unsigned int ovn_parse_internal_version_minor(const char *ver);

/* OVN Packet definitions. These may eventually find a home in OVS's
* packets.h file. For the time being, they live here because OVN uses them
* and OVS does not.
Expand Down

0 comments on commit c3d8797

Please sign in to comment.