[dgw]ovn-controller might miss openflow for the cr-lrp until recompute after change gateway chassis priority

[shylou]

version: ovn-21.09
scenario describe:
we create a logical router named share_router, and connected a logical switch named public_net. And we have created a localnet port bridged to br-ex for public_net .
There are distribute gateway chassis : node-1, node-2, node-3, and every chassis has been configed chassis-mac.

• node-1: fe4d81e2-2265-4fae-aede-18632e0aaacf
• node-2: 6999fad3-7268-4d67-ad5f-38801c75d356
• node-3: d9c27cf8-8eab-46d0-8c27-0288d2e2fc87

reproduce steps:
1.create lrp, and set lrp gateway chassis order [node-2, node-1, node-3] :

ovn-nbctl lrp-get-gateway-chassis **lrp-13786dc6-97b8-4038-8c0b-fef509390c1f**
lrp-13786dc6-97b8-4038-8c0b-fef509390c1f-6999fad3-7268-4d67-ad5f-38801c75d356     8
lrp-13786dc6-97b8-4038-8c0b-fef509390c1f-fe4d81e2-2265-4fae-aede-18632e0aaacf     7
lrp-13786dc6-97b8-4038-8c0b-fef509390c1f-d9c27cf8-8eab-46d0-8c27-0288d2e2fc87     6

With this patch [1], ovn-controller would not replace router port mac on gateway chassis, we could find open-flow tables worked fine on master gateway node-2.

2.change the priority of node-1, let it has highest priority , chassis order changed to [node-1, node-2 node-3] ：

ovn-nbctl lrp-get-gateway-chassis lrp-13786dc6-97b8-4038-8c0b-fef509390c1f
lrp-13786dc6-97b8-4038-8c0b-fef509390c1f-fe4d81e2-2265-4fae-aede-18632e0aaacf     9
lrp-13786dc6-97b8-4038-8c0b-fef509390c1f-6999fad3-7268-4d67-ad5f-38801c75d356     8
lrp-13786dc6-97b8-4038-8c0b-fef509390c1f-d9c27cf8-8eab-46d0-8c27-0288d2e2fc87     6

we could find open-flow tables related cr-lrp have been not changed on node-1.

analysis belows:
This patch[1] is related localnet port , not cr-lrp. So I think we should also process locanet port in processing of cr-lrp if its datapath has localnet port.

we can fix it in func physical_handle_flows_for_lport.

anyone has another opion?

[1][ovs-dev] [PATCH v1 1/4] OVN: Do not replace router port mac on gateway chassis.: