Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

northd, lsp: Arp proxy additional features #176

Closed
wants to merge 1 commit into from

Conversation

qinqon
Copy link
Contributor

@qinqon qinqon commented Feb 13, 2023

Add the following additional features to arp proxy:

  • IPv6 support
  • Fixed MAC
  • cidr match

@qinqon qinqon force-pushed the arp-proxy-additional-features branch 2 times, most recently from 1388a17 to 086b17b Compare February 13, 2023 14:48
@qinqon
Copy link
Contributor Author

qinqon commented Feb 14, 2023

The IPv6 neighbour solicitation is fine and the icmp destination mac is fine too but OVN is not answering to it

00:00:00.106114 f0:00:00:01:02:03 > 33:33:ff:00:00:01, ethertype IPv6 (0x86dd), length 86: (hlim 255, next-header ICMPv6 (58) payload length: 32) fd11::2 > ff02::1:ff00:1: [icmp6 sum ok] ICMP6, neighbor solicitation, length 32, who has fd7b:6b4d:7b25:d22f::1
	  source link-address option (1), length 8 (1): f0:00:00:01:02:03
	    0x0000:  f000 0001 0203
 00:00:00.000564 0a:58:a9:fe:01:01 > f0:00:00:01:02:03, ethertype IPv6 (0x86dd), length 86: (hlim 255, next-header ICMPv6 (58) payload length: 32) fd7b:6b4d:7b25:d22f::1 > fd11::2: [icmp6 sum ok] ICMP6, neighbor advertisement, length 32, tgt is fd7b:6b4d:7b25:d22f::1, Flags [router, solicited, override]
	  destination link-address option (2), length 8 (1): 0a:58:a9:fe:01:01
	    0x0000:  0a58 a9fe 0101
 00:00:00.000009 f0:00:00:01:02:03 > 0a:58:a9:fe:01:01, ethertype IPv6 (0x86dd), length 118: (flowlabel 0x0d8dd, hlim 64, next-header ICMPv6 (58) payload length: 64) fd11::2 > fd12::2: [icmp6 sum ok] ICMP6, echo request, id 3072, seq 1
 00:00:00.299817 f0:00:00:01:02:03 > 0a:58:a9:fe:01:01, ethertype IPv6 (0x86dd), length 118: (flowlabel 0x0d8dd, hlim 64, next-header ICMPv6 (58) payload length: 64) fd11::2 > fd12::2: [icmp6 sum ok] ICMP6, echo request, id 3072, seq 2

@qinqon qinqon force-pushed the arp-proxy-additional-features branch 5 times, most recently from f5876d3 to d73a239 Compare February 16, 2023 12:24
@qinqon qinqon force-pushed the arp-proxy-additional-features branch 2 times, most recently from c1dd5a5 to c16e5e4 Compare February 21, 2023 12:50
@qinqon qinqon changed the title wip: Arp proxy additional features Arp proxy additional features Feb 21, 2023
@qinqon qinqon force-pushed the arp-proxy-additional-features branch 2 times, most recently from 191b4ad to 12d2a1b Compare February 21, 2023 13:06
@qinqon qinqon changed the title Arp proxy additional features northd, lsp: Arp proxy additional features Feb 21, 2023
@qinqon qinqon force-pushed the arp-proxy-additional-features branch from 12d2a1b to eb1611e Compare February 21, 2023 13:45
Copy link
Contributor

@almusil almusil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
there are some questions about the approach and small issue with memory management, but other than that it looks good. Thanks!

northd/northd.c Outdated Show resolved Hide resolved
northd/northd.c Outdated Show resolved Hide resolved
northd/northd.c Outdated Show resolved Hide resolved
northd/northd.c Outdated Show resolved Hide resolved
northd/northd.c Outdated Show resolved Hide resolved
tests/system-ovn.at Outdated Show resolved Hide resolved
tests/system-ovn.at Outdated Show resolved Hide resolved
tests/system-ovn.at Outdated Show resolved Hide resolved
tests/system-ovn.at Outdated Show resolved Hide resolved
tests/system-ovn.at Show resolved Hide resolved
northd/northd.c Outdated Show resolved Hide resolved
northd/northd.c Outdated Show resolved Hide resolved
@qinqon qinqon force-pushed the arp-proxy-additional-features branch from eb1611e to 323f668 Compare February 22, 2023 12:33
@qinqon qinqon requested a review from almusil February 22, 2023 12:33
@qinqon qinqon force-pushed the arp-proxy-additional-features branch from 323f668 to 73fa03f Compare February 22, 2023 12:40
Copy link
Contributor

@almusil almusil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it looks better a few additional things.

northd/northd.c Show resolved Hide resolved
northd/northd.c Show resolved Hide resolved
northd/northd.c Outdated Show resolved Hide resolved
northd/northd.c Outdated Show resolved Hide resolved
northd/northd.c Outdated Show resolved Hide resolved
@qinqon qinqon force-pushed the arp-proxy-additional-features branch 7 times, most recently from d3cec31 to 9ff78be Compare February 23, 2023 10:08
@qinqon qinqon force-pushed the arp-proxy-additional-features branch 21 times, most recently from 0e45537 to 9e3feee Compare February 28, 2023 09:51
@qinqon qinqon force-pushed the arp-proxy-additional-features branch 5 times, most recently from 58e9b90 to 8009c61 Compare March 8, 2023 12:07
Configure mac address
The mac address returned by ARP/NDP can be configured similar to LSP
addresses where the mac is the first entry on the list

IPv6
Support NDP IPv6 protocol

Use CIDRs
Allow to specify subnets for ipv4 and ipv6, they will match whatever
address is received from ARP/NDP

Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants