Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dgw] Avoid snat on reply packets #214

Closed
wants to merge 1 commit into from
Closed

Conversation

shylou
Copy link
Contributor

@shylou shylou commented Sep 8, 2023

#212
OVN had fix the issue[1] that avoid snat on reply packets for gateway router. And it is also needed be dealt with for dgw.

[1]8b3e1afc30

Copy link
Contributor Author

@shylou shylou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test this please

@shylou shylou force-pushed the dgw-snat branch 2 times, most recently from 6b5eea9 to 493fbba Compare September 9, 2023 14:26
OVN had fix the issue[1] that avoid snat on reply packets for
gateway router. It is also needed to be dealt with for dgw.

[1]ovn-org@8b3e1afc30

Signed-off-by: Xie Liu <liushyshy@gmail.com>
@dceara
Copy link
Collaborator

dceara commented Sep 12, 2023

Hi @shylou! This change looks good to me at a first glance. Would you mind posting this as a formal patch to the mailing list? Instructions are available here:
https://github.com/ovn-org/ovn/blob/main/Documentation/internals/contributing/submitting-patches.rst

Essentially it's something like:

p=$(git format-patch --subject-prefix="PATCH ovn" -M HEAD~)
git send-email $p

Please also make sure you sign-off your commit:
https://github.com/ovn-org/ovn/blob/main/Documentation/internals/contributing/submitting-patches.rst#developers-certificate-of-origin

git commit -s --ammend

Thanks,
Dumitru

@shylou
Copy link
Contributor Author

shylou commented Sep 12, 2023

hi @dceara, i have posted this patch to dev@openvswitch.org. Please review it, thanks.

@dceara
Copy link
Collaborator

dceara commented Oct 10, 2023

@dceara dceara closed this Oct 10, 2023
@shylou shylou deleted the dgw-snat branch October 16, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants