Add support for DHCP Options 44,46 (NB Name Server, NB Node Type) #66
Conversation
odivlad
force-pushed
the
netbios-dhcp-options
branch
2 times, most recently
from
776612c
to
1d2f87c
Compare
Signed-off-by: Vladislav Odintsov <odivlad@gmail.com>
odivlad
force-pushed
the
netbios-dhcp-options
branch
from
1d2f87c
to
5655f62
Compare
|
@numansiddique, Hi, could you please take a look on this? |
| </p> | ||
| </column> | ||
|
|
||
| <column name="options" key="netbios_node_type"> |
There was a problem hiding this comment.
The patch LGTM.
Can you please move the documentation for this option - netbios_node_type to the appropriate section i.e here - https://github.com/ovn-org/ovn/blob/master/ovn-nb.xml#L3115
|
Actually never mind. The patch LGTM. |
Submitted-at: ovn-org#66 Signed-off-by: Vladislav Odintsov <odivlad@gmail.com> Signed-off-by: 0-day Robot <robot@bytheb.org>
Submitted-at: #66 Signed-off-by: Vladislav Odintsov <odivlad@gmail.com> Signed-off-by: Numan Siddique <numans@ovn.org>
|
Applied the patch. Closing the PR. |
|
@numansiddique, thanks. |
|
@odivlad Since it is a feature/enhancement and not a bug fix. we don't normally backport to the branches. How do you consume OVN ? If you build yourself, then I would suggest to backport this patch yourself. |
|
We do build 20.06 by our internal build systems. Sure we can backport by ourself, but since there are changes in tests, each time there would be merge conflicts. If it's possible to backport, it would be appreciated. If not, well okay :) |
Signed-off-by: Vladislav Odintsov odivlad@gmail.com