[aws-rotate-keys] Default to installing the latest AWS CLI v2 if the binary is not present on the PATH #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwz
requested review from
sundeepkovo,
eversC,
a team,
apjm,
paulreevo and
katebee-kaluza
and removed request for
sundeepkovo and
a team
|
@ovotech/dex any chance I could get a review on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue with the version
'2'that was specified previously which made the job fail if the default executor was used since the install command requires a full version to be specified. I've made it use the latest v2 version by omitting the version parameter.